Task notes - fix opening URLs in new window#3193
Open
4oo4 wants to merge 1 commit into
Open
Conversation
Add the target="_blank" back to the <a> that is stripped out by DOMPurify. Set rel="nofollow noopener noreferrer" to harden against reverse tabnabbing Signed-off-by: 4oo4 <4oo4@users.noreply.github.com> Assisted-by: Claude:claude-opus-4-8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the
target="_blank"back to the<a>that is stripped out byDOMPurify. Setrel="nofollow noopener noreferrer"to harden against reverse tabnabbing.I just saw the DCO real name requirement after opening the PR, if this isn't considered trivial feel free to close and have a maintainer recommit.
🤖 AI (if applicable)
or fullygenerated using AI.I used Claude Opus 4.8 (chat, not Claude Code) to help me find why the
targetwas being stripped out, and it suggested the additionalrelhardening.